Skip to content

fix(api): remove arguments of unmount api #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 1, 2021
Merged

fix(api): remove arguments of unmount api #770

merged 2 commits into from
Jan 1, 2021
+2 −6

Conversation

underfin
Copy link
Member

@underfin underfin commented Jan 1, 2021

Description of Problem

See vuejs/core#2922

Proposed Solution

Fixed here vuejs/core#2922

Additional Information

skirtles-code
skirtles-code suggested changes Jan 1, 2021
View reviewed changes
Copy link
Contributor

@skirtles-code skirtles-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the words:

on the provided DOM element

from the Usage section should also be removed.

NataliaTepluhina
NataliaTepluhina reviewed Jan 1, 2021
View reviewed changes
@NataliaTepluhina NataliaTepluhina merged commit 5192278 into vuejs:master Jan 1, 2021
@underfin underfin deleted the api-unmout branch January 2, 2021 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NataliaTepluhina NataliaTepluhina NataliaTepluhina left review comments

+1 more reviewer

@skirtles-code skirtles-code skirtles-code requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@underfin @NataliaTepluhina @skirtles-code