-
-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vue/require-component-is false positive #869
Comments
[edit] I edited the original post instead to narrow down the problem. Even removing all the /home/jmasson/dev/tuleap/PostActionsSection.vue
2:1 warning Expected indentation of 2 spaces but found 4 spaces vue/html-indent
2:5 error Expected '<component>' elements to have 'v-bind:is' attribute vue/require-component-is
2:29 warning Expected a space before '/>', but not found vue/html-closing-bracket-spacing
✖ 3 problems (1 error, 2 warnings)
0 errors and 2 warnings potentially fixable with the `--fix` option. |
Part of request #13228 Upgrade dev dependencies April 2019 edition No functional change expected. Note to reviewer: I tried to fix as many errors as possible but there are still errors such as: The template root requires exactly one element vue/valid-template-root We should deal with those in dedicated patches. Changes to the configuration: Errors: - vue/match-component-file-name. It enforces the "name" property and the filename to be the same in Vue components. - vue/require-direct-export. It enforces to use "export default {" in Vue components. - vue/order-in-components now produces errors instead of warnings Disabled rules: - vue/multiline-html-element-content-newline and vue/singleline-html-element-content-newline have been disabled. They were set to "warning" by the vue/recommended config, but they are more annoying than useful. I would prefer to automatically format this with Prettier when it works. - vue/require-component-is has a bug [0] and is now disabled - vue/no-unused-components is too flaky. On the CLI it reports false positives, in the editor it doesn't report when it should (false negatives). It's therefore disabled. [0]: vuejs/eslint-plugin-vue#869 Change-Id: I35556cfaaa0d4a83172dde24be6ddb5e74d02d16
Any progress on getting this resolved? |
Thank you for this issue.
|
[edit] It turns out this only happens for
vue-eslint-parser@^6.0.0
. The parsing changes cause this.Tell us about your environment
Please show your full configuration:
What did you do?
I tried linting the following component in my project using the following command line:
What did you expect to happen?
I expected the component to be valid and no error to be reported.
What actually happened?
The rule fails because the parsing changed with vue-eslint-parser v6
The text was updated successfully, but these errors were encountered: