Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: vue/html-button-has-type rule #1001

Merged
merged 8 commits into from Feb 5, 2021
Merged

New: vue/html-button-has-type rule #1001

merged 8 commits into from Feb 5, 2021

Conversation

@SanterreJo
Copy link
Contributor

@SanterreJo SanterreJo commented Dec 7, 2019

No description provided.

@SanterreJo SanterreJo changed the title New: vue/html-button-has-type rule (fixes #894) New: vue/html-button-has-type rule Dec 8, 2019
@SanterreJo
Copy link
Contributor Author

@SanterreJo SanterreJo commented Dec 8, 2019

This rule fixes #894

@Etheryte
Copy link

@Etheryte Etheryte commented May 18, 2020

Thanks for putting in the hours to make this work. Can't wait to have it merged, would be insanely helpful on large codebases.

@miralize
Copy link

@miralize miralize commented Jul 21, 2020

This would be great to get into the next version!

@mrleblanc101
Copy link

@mrleblanc101 mrleblanc101 commented Oct 2, 2020

Almost a year, will this get merged ?

@ota-meshi
Copy link
Member

@ota-meshi ota-meshi commented Feb 4, 2021

Sorry for not commenting for very long time.

I thought it would be better to implement a rule that checks the required attributes of every element, using something like component data, rather than creating a <button> specific rule, but now I found it difficult to implement this generic rule.

Could you update this PR to resolve the conflict?

# Conflicts:
#	docs/rules/README.md
#	lib/configs/recommended.js
#	lib/index.js
@SanterreJo
Copy link
Contributor Author

@SanterreJo SanterreJo commented Feb 4, 2021

@ota-meshi
merge conflict is resolved

Copy link
Member

@ota-meshi ota-meshi left a comment

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants