Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RFC0015): add no-deprecated-filter rule #1043

Merged
merged 2 commits into from Mar 14, 2020

Conversation

@przemkow
Copy link
Contributor

@przemkow przemkow commented Feb 2, 2020

Add no-deprecated-filter rule

Relates to:
#1035
RFC0015

Scope:

  • vue/no-deprecated-filter - This rule reports usage of filters syntax removed in Vue.js 3.0.0+

Clarification needed:

  • This rule is based on VFilterSequenceExpression. As Vue.js 3 is going to drop support for filters, are they any plans to drop support for that node in AST generated by vue-eslint-parser?
    It seems like a reasonable move as {{ 0b0001 | 0b0010 }} in Vue.js 3 AST should be probably interpreted as BinaryExpression
@ota-meshi
Copy link
Member

@ota-meshi ota-meshi commented Feb 19, 2020

Thank you for this PR.

I think people rarely do bitwise operations on templates. So I don't think there is a problem, but if you strictly parse it, you need to work on adding options to "vue-eslint-parser".

@ota-meshi ota-meshi merged commit bd770c2 into vuejs:master Mar 14, 2020
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants