Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring #1154

Merged
merged 2 commits into from May 21, 2020
Merged

Refactoring #1154

merged 2 commits into from May 21, 2020

Conversation

@ota-meshi
Copy link
Member

@ota-meshi ota-meshi commented May 21, 2020

  • Made the side effect analysis logic of the "no-side-effects-in-computed-properties" rule common.
  • Made the setup function visit common.
  • Made the Vue object visit common.
@ota-meshi ota-meshi merged commit e80c2f0 into master May 21, 2020
9 checks passed
@ota-meshi ota-meshi deleted the refactor-no-side-effects-in-computed-properties branch May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant