Add new vue/no-arrow-functions-in-watch rule#1155
Merged
ota-meshi merged 3 commits intoMay 23, 2020
Merged
Conversation
ota-meshi
requested changes
May 21, 2020
ota-meshi
left a comment
ota-meshi
left a comment
Member
There was a problem hiding this comment.
Thank you for this PR!
I have some requests.
| 'e.f': function (val, oldVal) { /* ... */ } | ||
| } | ||
| }`, | ||
| errors: ['You should not use an arrow function to define a watcher.'] |
Member
There was a problem hiding this comment.
Could you check the location with some test cases?
Suggested change
| errors: ['You should not use an arrow function to define a watcher.'] | |
| errors: [ | |
| { | |
| message: 'You should not use an arrow function to define a watcher.', | |
| line: ? | |
| } | |
| ] |
| return | ||
| } | ||
| for (const property of watchValue.properties) { | ||
| if (property.value.type === 'ArrowFunctionExpression') { |
Member
There was a problem hiding this comment.
Could you check type is a "Property"?
Probably get an error with "SpreadElement".
https://github.com/estree/estree/blob/master/es2015.md#expressions
https://github.com/estree/estree/blob/master/es2018.md#expressions
ota-meshi
approved these changes
May 21, 2020
ota-meshi
left a comment
ota-meshi
left a comment
Member
There was a problem hiding this comment.
Thank you for your quick response! Looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1113
If this rules should be categorized please let me know