Add allowProps option to vue/require-explicit-emits rule.
#1259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even if you declare it in props, a warning message and fallthrough can be stopped, so I add an option to allow this. https://github.com/vuejs/vue-next/blob/00ab9e2e8506d108958895cda4e977dfb16b53f9/packages/runtime-core/src/componentEmits.ts#L50 By default this option remains disabled.
|
@ota-meshi This doesn't seem to account for custom events in kebab-case declared as a prop, do you think we should add this to support the workaround mentioned here: For example currently this does work but is ugly and violates vue/prop-name-casing: props: ['onCustom-event'],
// ...
this.$emit('custom-event')So it would be great if we can do: props: ['onCustomEvent'],
// ...
this.$emit('custom-event') |
Robo-Rin
added a commit
to Robo-Rin/eslint-plugin-vue
that referenced
this pull request
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if you declare it in props, a warning message and fallthrough can be stopped, so I add an option to allow this.
https://github.com/vuejs/vue-next/blob/00ab9e2e8506d108958895cda4e977dfb16b53f9/packages/runtime-core/src/componentEmits.ts#L50
By default this option remains disabled.