Skip to content

Fix: support ESLint 4.4.0 (fixes #134) #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2017
Merged

Fix: support ESLint 4.4.0 (fixes #134) #139

merged 1 commit into from
Aug 8, 2017

Conversation

mysticatea
Copy link
Member

@mysticatea mysticatea commented Aug 7, 2017 •
edited
Loading

Fixes #134.

This PR fixes the problem that eslint-plugin-vue does not work on ESLint 4.4.0 because it has changed a private API that vue-eslint-parser depends on.

Diff:

The root cause is that vue-eslint-parser depends on a private API in order to traverse <template> separately from the main traversing, but I cannot solve the problem for now.

@michalsnik michalsnik merged commit 8761bde into master Aug 8, 2017
@michalsnik michalsnik deleted the issue134 branch November 23, 2017 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@armano2 armano2 armano2 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
semver-patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maybe not compatible with ESLint@4.4.0
3 participants
@mysticatea @armano2 @michalsnik