Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vue/no-constant-condition rule #1401

Merged
merged 5 commits into from Jan 3, 2021

Conversation

@FloEdelmann
Copy link
Contributor

@FloEdelmann FloEdelmann commented Dec 30, 2020

Closes #1358.

Copy link
Member

@ota-meshi ota-meshi left a comment

Thank you for this PR! I have 2 requests.

tests/lib/rules/no-constant-condition.js Outdated Show resolved Hide resolved
lib/rules/no-constant-condition.js Outdated Show resolved Hide resolved
docs/rules/no-constant-condition.md Outdated Show resolved Hide resolved
@FloEdelmann FloEdelmann requested a review from ota-meshi Jan 2, 2021
Copy link
Member

@ota-meshi ota-meshi left a comment

LGTM! Thank you for your contribution!

@ota-meshi ota-meshi merged commit 6b62278 into vuejs:master Jan 3, 2021
10 checks passed
@FloEdelmann FloEdelmann deleted the no-constant-condition branch Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants