Skip to content

Conversation

FloEdelmann
Copy link
Member

Closes #1358.

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR! I have 2 requests.

@FloEdelmann FloEdelmann requested a review from ota-meshi January 2, 2021 12:08
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution!

@ota-meshi ota-meshi merged commit 6b62278 into vuejs:master Jan 3, 2021
@FloEdelmann FloEdelmann deleted the no-constant-condition branch January 3, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule Proposal: vue/no-constant-condition
2 participants