Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/rules/syntaxes/slot-attribute.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ module.exports = {
return true
}
const slotName = slotAttr.value.value
// If non-Latin characters are included it can not be converted.
return !/[^a-z]/i.test(slotName)
// If other than alphanumeric, underscore and hyphen characters are included it can not be converted.
return !/[^\w\-]/u.test(slotName)
}

/**
Expand Down
57 changes: 57 additions & 0 deletions tests/lib/rules/no-deprecated-slot-attribute.js
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,63 @@ tester.run('no-deprecated-slot-attribute', rule, {
line: 4
}
]
},
{
code: `
<template>
<MyComponent>
<template slot="foo-bar">
<a/>
</template>
</MyComponent>
</template>`,
output: `
<template>
<MyComponent>
<template v-slot:foo-bar>
<a/>
</template>
</MyComponent>
</template>`,
errors: ['`slot` attributes are deprecated.']
},
{
code: `
<template>
<MyComponent>
<template slot="foo_bar">
<a/>
</template>
</MyComponent>
</template>`,
output: `
<template>
<MyComponent>
<template v-slot:foo_bar>
<a/>
</template>
</MyComponent>
</template>`,
errors: ['`slot` attributes are deprecated.']
},
{
code: `
<template>
<MyComponent>
<template slot="123">
<a/>
</template>
</MyComponent>
</template>`,
output: `
<template>
<MyComponent>
<template v-slot:123>
<a/>
</template>
</MyComponent>
</template>`,
errors: ['`slot` attributes are deprecated.']
}
]
})