Skip to content

Update: allow more cases in require-direct-export #1450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2021
Merged

Update: allow more cases in require-direct-export #1450

merged 1 commit into from
Mar 22, 2021

Conversation

g-plane
Copy link
Contributor

@g-plane g-plane commented Mar 3, 2021

This PR allows two cases below with rule require-direct-export enabled:

import Vue from 'vue'

export default Vue.extend({})
import { defineComponent } from 'vue'

export default defineComponent({})

which will benefit TypeScript users.

Fixes #907

ota-meshi
ota-meshi approved these changes Mar 5, 2021
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR! I would like to include this change in the next release.

@ota-meshi ota-meshi merged commit ff8cfaa into vuejs:master Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ota-meshi ota-meshi ota-meshi approved these changes

Assignees
No one assigned
Labels
semver-minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

require-direct-export rule doesn't work with export default Vue.extend({})
2 participants
@g-plane @ota-meshi