Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: allow more cases in require-direct-export #1450

Merged
merged 1 commit into from Mar 22, 2021
Merged

Update: allow more cases in require-direct-export #1450

merged 1 commit into from Mar 22, 2021

Conversation

@g-plane
Copy link
Contributor

@g-plane g-plane commented Mar 3, 2021

This PR allows two cases below with rule require-direct-export enabled:

import Vue from 'vue'

export default Vue.extend({})
import { defineComponent } from 'vue'

export default defineComponent({})

which will benefit TypeScript users.

Fixes #907

Copy link
Member

@ota-meshi ota-meshi left a comment

Thank you for this PR! I would like to include this change in the next release.

@ota-meshi ota-meshi merged commit ff8cfaa into vuejs:master Mar 22, 2021
10 checks passed
10 checks passed
@netlify
Header rules No header rules processed
Details
@netlify
Pages changed 197 new files uploaded
Details
@netlify
Redirect rules No redirect rules processed
Details
@netlify
Mixed content No mixed content detected
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: node-v10 Your tests passed on CircleCI!
Details
ci/circleci: node-v12 Your tests passed on CircleCI!
Details
ci/circleci: node-v14 Your tests passed on CircleCI!
Details
ci/circleci: node-v8 Your tests passed on CircleCI!
Details
@netlify
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants