Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positives for import binding in vue/valid-define-emits and vue/valid-define-props rules #1736

merged 3 commits into from Dec 3, 2021


Copy link

close #1734

@ota-meshi ota-meshi added the bug label Dec 3, 2021
lib/rules/valid-define-emits.js Outdated Show resolved Hide resolved
lib/rules/valid-define-props.js Outdated Show resolved Hide resolved
ota-meshi and others added 2 commits December 3, 2021 20:03
Co-authored-by: Flo Edelmann <>
Copy link
Member Author

Thank you for your review! I changed this PR.

@ota-meshi ota-meshi merged commit 09d7bed into master Dec 3, 2021
@ota-meshi ota-meshi deleted the issue1734 branch December 3, 2021 14:23
Copy link

hi ,does this plugin now support verify defineEmits(['onSuccess']) case?
like :

defineEmits(['onSuccess'])  // bad
defineEmits(['on-success'])  // good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

defineProps should be able to work with local imported bindings, but reported as error
3 participants