Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename vue/no-invalid-attribute-name rule to vue/invalid-attribute-name and add it to presets #1892

Merged
merged 2 commits into from May 17, 2022

Conversation

ota-meshi
Copy link
Member

@ota-meshi ota-meshi commented May 17, 2022

No description provided.

@ota-meshi ota-meshi requested a review from FloEdelmann May 17, 2022
@FloEdelmann
Copy link
Member

FloEdelmann commented May 17, 2022

Maybe before we release v9, should we rename no-invalid-attribute-name to valid-attribute-name for consistency?

@ota-meshi
Copy link
Member Author

ota-meshi commented May 17, 2022

I think it's a good idea to rename the rule. I will rename in this PR.

@ota-meshi ota-meshi changed the title Add vue/no-invalid-attribute-name rule to the presets Rename vue/no-invalid-attribute-name rule to vue/invalid-attribute-name and add it to presets May 17, 2022
@ota-meshi ota-meshi merged commit 6bd81ea into master May 17, 2022
14 checks passed
@ota-meshi ota-meshi deleted the update-config branch May 17, 2022
@ota-meshi
Copy link
Member Author

ota-meshi commented May 17, 2022

Thank you for checking! I will release v9 tomorrow if I have time.

@FloEdelmann
Copy link
Member

FloEdelmann commented May 17, 2022

I already updated the changelog draft in #1850, so releasing should be as straightforward as possible.

@FloEdelmann
Copy link
Member

FloEdelmann commented May 18, 2022

@ota-meshi The documentation for this rule is not yet published. Maybe the npm cache needs to be cleared for the production build, too?

https://eslint.vuejs.org/rules/valid-attribute-name.html

@ota-meshi
Copy link
Member Author

ota-meshi commented May 18, 2022

Thank you for letting me know. I cleared the cache and redeployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants