Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suggestion for vue/require-name-property rule #2034

Merged
merged 1 commit into from Nov 16, 2022

Conversation

0xYootou
Copy link
Contributor

this is a pull request for issues: #2033

@FloEdelmann FloEdelmann linked an issue Nov 10, 2022 that may be closed by this pull request
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion and the implementation!

Can we always auto-fix this to the filename or should we rather only add a suggestion for that, which the user can manually apply?

Also, please see the issues below.

lib/rules/require-name-property.js Outdated Show resolved Hide resolved
lib/rules/require-name-property.js Show resolved Hide resolved
lib/rules/require-name-property.js Outdated Show resolved Hide resolved
@0xYootou
Copy link
Contributor Author

ok, i think add a suggestion for that is better too, i will rewrite the code and add test case.

@0xYootou
Copy link
Contributor Author

i push new code for this feature, and add some new test case for this rule and suggestions.

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

lib/rules/require-name-property.js Outdated Show resolved Hide resolved
lib/rules/require-name-property.js Outdated Show resolved Hide resolved
@FloEdelmann FloEdelmann changed the title feat: rule fixer for require-name-property Add suggestion for vue/require-name-property rule Nov 16, 2022
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now. Thanks for the changes!

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit cc1b8d9 into vuejs:master Nov 16, 2022
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule suggestion: add fixer to require-name-property rule
3 participants