Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable autofix in vue/attribute-hyphenation for attributes with underscore #2045

Merged
merged 7 commits into from Nov 23, 2022

Conversation

kurageso
Copy link
Contributor

fixes #924

I have modified it in reference to #924 (comment)

Please let me know if you need anything else. Thanks!

tests/lib/rules/attribute-hyphenation.js Outdated Show resolved Hide resolved
tests/lib/rules/attribute-hyphenation.js Outdated Show resolved Hide resolved
@kurageso kurageso changed the title fix(vue/attribute-hyphenation): disable autofix to kebab case if attribute name contains _ fix(vue/attribute-hyphenation): disable autofix if attribute name contains _ Nov 23, 2022
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and the quick implementation of the feedback!

@FloEdelmann FloEdelmann changed the title fix(vue/attribute-hyphenation): disable autofix if attribute name contains _ Disable autofix in vue/attribute-hyphenation if attribute name contains _ Nov 23, 2022
@FloEdelmann FloEdelmann changed the title Disable autofix in vue/attribute-hyphenation if attribute name contains _ Disable autofix in vue/attribute-hyphenation for attributes with underscore Nov 23, 2022
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ota-meshi ota-meshi merged commit ec0276b into vuejs:master Nov 23, 2022
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vue/attribute-hyphenation changes original code which would break app
3 participants