Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

html-end-tags: don't fail for self-closing elements #221

Merged
merged 3 commits into from
Oct 27, 2017
Merged

html-end-tags: don't fail for self-closing elements #221

merged 3 commits into from
Oct 27, 2017

Conversation

mariolamacchia
Copy link
Contributor

Fixes #217

@mariolamacchia
Copy link
Contributor Author

Hey guys! A question: should <br /> be valid or not?

@mysticatea
Copy link
Member

Thank you for contributing!

LGTM.

<br /> is valid in HTML spec because it's a void element.
People can control preference between <br> and <br/> by vue/html-self-closing rule.

In background of this bug, actually, <div/> is non-void-html-element-start-tag-with-trailing-solidus error in HTML spec. This rule was created on early time I didn't know Vue.js supports the trailing solidus even if it's a non-void HTML element.

@mysticatea mysticatea merged commit 43f248b into vuejs:master Oct 27, 2017
@mariolamacchia mariolamacchia deleted the html-end-tag-self-closing branch November 8, 2017 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mysticatea mysticatea mysticatea approved these changes

Assignees
No one assigned
Labels
semver-patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mariolamacchia @mysticatea