Fix incompatibility with typescript-eslint v6 in vue/script-indent rule
#2256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ota-meshi
commented
Jul 29, 2023
ota-meshi
commented
Jul 29, 2023
FloEdelmann
reviewed
Jul 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the typescript-eslint we use in our tests to v6 and found a bug in the script-indent rule, so I fix it.
This PR also updates the typescript-eslint we use in our tests to v6 and adds a workflow to test using typescript-eslint@v5.
I think we can close #2227 as this PR adds compatibility testing with typescript-eslint v6.
close #2227