Skip to content

(fixes #230) Fix assignment check in no-side-effects-in-computed-property #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2017
Merged

(fixes #230) Fix assignment check in no-side-effects-in-computed-property #231

merged 1 commit into from
Nov 16, 2017

Conversation

michalsnik
Copy link
Member

This PR fixes #230

@michalsnik michalsnik merged commit b23c518 into master Nov 16, 2017
@michalsnik michalsnik deleted the fix-no-side-effects-in-computed-property branch November 16, 2017 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mysticatea mysticatea Awaiting requested review from mysticatea

1 more reviewer

@chrisvfritz chrisvfritz chrisvfritz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positive in no-side-effects-in-computed-properties
2 participants
@michalsnik @chrisvfritz