Skip to content

Conversation

ItMaga
Copy link
Contributor

@ItMaga ItMaga commented Nov 13, 2023

closes #1901

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks mostly good to me, apart from two minor nitpicks.

}
})

tester.run('no-unused-emit-declarations', rule, {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice and extensive tests! 👍

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry for the late review.

@ota-meshi ota-meshi merged commit 4db54a7 into vuejs:master Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule proposal: vue/no-unused-emit-declarations
3 participants