Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated rules #232

Merged
merged 3 commits into from
Nov 17, 2017
Merged

Remove deprecated rules #232

merged 3 commits into from
Nov 17, 2017

Conversation

michalsnik
Copy link
Member

No description provided.

chrisvfritz
chrisvfritz approved these changes Nov 16, 2017
View reviewed changes
Copy link
Contributor

@chrisvfritz chrisvfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but should we conditionally generate the Deprecated section only if any deprecated rules exist?

@mysticatea
Copy link
Member

Thank you!

I agree with @chrisvfritz about the conditional Deprecated section.

@michalsnik
Copy link
Member Author

Makes sense. Done @chrisvfritz @mysticatea :)

@michalsnik michalsnik merged commit 0f18b3b into master Nov 17, 2017
@michalsnik michalsnik deleted the remove-deprecated-rules branch November 17, 2017 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisvfritz chrisvfritz chrisvfritz approved these changes

Assignees
No one assigned
Labels
semver-major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@michalsnik @mysticatea @chrisvfritz