Breaking: enable HTML syntax errors by default #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalsnik
approved these changes
Nov 17, 2017
michalsnik
deleted the
no-parsing-error/enable-html-errors-by-default
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables HTML syntax errors by default.
Currently,
no-parsing-errorrule reports HTML syntax errors (e.g. invalid end tags, duplicated attributes, ...) by opt-in because of backward compatibility. I think the errors are valuable to prevent mistakes, so I'd like to enable those by default before the next major release.This PR keeps only non-void-html-element-start-tag-with-trailing-solidus error as is because Vue.js supports self-closing tags.