Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(no-setup-props-reactivity-loss): false negative for conditional expressions #2394

Merged

Conversation

thesheppard
Copy link
Contributor

Fix #2352

@thesheppard thesheppard changed the title fix(no-setup-reactivity-loss): false negative for conditional expressions fix(no-setup-props-reactivity-loss): false negative for conditional expressions Feb 3, 2024
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! 🙂

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ota-meshi ota-meshi merged commit 16aba2c into vuejs:master Feb 18, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vue/setup-props-no-reactivity-loss: false negative inside ternary operator
3 participants