[Update] Make vue/no-shared-component-data fixable
#278
Conversation
| let last = sourceCode.getLastToken(p.value) | ||
|
|
||
| // If the value enclosed by parentheses, update the 'first' and 'last' by the parentheses. | ||
| let t = null |
There was a problem hiding this comment.
I think we should use more descriptive variables, t and u doesn't mean much.
| // If the value enclosed by parentheses, update the 'first' and 'last' by the parentheses. | ||
| let t = null | ||
| let u = null | ||
| while (isOpenParen(t = sourceCode.getTokenBefore(first)) && isCloseParen(u = sourceCode.getTokenAfter(last))) { |
There was a problem hiding this comment.
I think we should avoid assigning values in function params, it's kind of confusing. Please simplify this part and wrap too long line.
| // See: https://eslint.org/blog/2017/06/eslint-v4.1.0-released#applying-multiple-autofixes-simultaneously | ||
| const range = [first.range[0], last.range[1]] | ||
| const valueText = sourceCode.text.slice(range[0], range[1]) | ||
| const replacement = `function() {\nreturn ${valueText};\n}` |
There was a problem hiding this comment.
Can't we replace it with data() {} instead of a function?
There was a problem hiding this comment.
I think that a function expression is better to keep the rule simple.
If we want to fix to a method shorthand, it needs extra check the object-shorthand rule is doing. I.e., if comments exist between the key and the value, the rule should not autofix it to avoid removing the comments.
There was a problem hiding this comment.
Ah, alright. There is already object-shorthand core rule, that is fixable, so it should take care of it :) I forgot about it.
michalsnik
changed the title
vue/no-shared-component-data fixable
|
Updated about |
|
Good job @mysticatea 🙌 |
This PR makes
vue/no-shared-component-datafixable. The autofix wraps thedataproperty's value by a function expression.At first glance, the unit tests make wrong indentations, but this is intentional. This strategy is same as core rules; one rule does one thing. A combination of rules will make correct autofix.