-
-
Notifications
You must be signed in to change notification settings - Fork 696
feat(component-name-in-template-casing): global
option support regex
#2928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 80f2630 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the component-name-in-template-casing
rule to support regex patterns in the globals
option, allowing users to match component names with patterns instead of only exact string matches.
- Added regex pattern support to the
globals
option for more flexible component name matching - Updated rule implementation to handle both string literals and regex patterns
- Added comprehensive test coverage for the new regex functionality
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
File | Description |
---|---|
lib/rules/component-name-in-template-casing.js | Updated rule logic to parse and handle regex patterns in globals option |
tests/lib/rules/component-name-in-template-casing.js | Added test cases for valid and invalid scenarios with regex patterns |
docs/rules/component-name-in-template-casing.md | Updated documentation with examples of regex pattern usage |
.changeset/rude-heads-serve.md | Added changelog entry for the new feature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 🙂
resolve #2912