Skip to content

Fix: unintentional disabling #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2018
Merged

Fix: unintentional disabling #331

merged 1 commit into from
Jan 7, 2018

Conversation

mysticatea
Copy link
Member

@mysticatea mysticatea commented Jan 7, 2018 •
edited
Loading

<!-- eslint-disable-line foo --> was parsed to <!-- eslint-disable -line foo --> (i.e. disable 2 rules -line and foo after the comment) wrongly. This PR fixes the bug -- it requires one or more spaces between eslint-disable and the first rule name.

This is a bug fix which increases warnings, so needs semver-minor.

@mysticatea mysticatea requested a review from michalsnik January 7, 2018 07:37
@mysticatea mysticatea added this to the v4.2.0 milestone Jan 7, 2018
@michalsnik michalsnik merged commit f3c609d into master Jan 7, 2018
@mysticatea mysticatea deleted the fix-comment-directive branch January 7, 2018 15:20
@mysticatea mysticatea mentioned this pull request Jan 8, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@michalsnik michalsnik michalsnik approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug semver-minor
Projects
None yet
Milestone
v4.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mysticatea @michalsnik