Skip to content

(Fixes #416) Allow "default" key to be used also as a Literal #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2018
Merged

(Fixes #416) Allow "default" key to be used also as a Literal #463

merged 1 commit into from
Jul 11, 2018

Conversation

michalsnik
Copy link
Member

@michalsnik michalsnik commented Apr 21, 2018 •
edited
Loading

This PR fixes #416 by allowing users to use default key not only as Identifier, but also as a Literal in require-default-prop rule:

{
  'default': 0,
}

@michalsnik michalsnik self-assigned this Apr 21, 2018
@michalsnik michalsnik merged commit 552ea4f into master Jul 11, 2018
@michalsnik michalsnik deleted the fix-require-default-property branch July 11, 2018 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@chrisvfritz chrisvfritz chrisvfritz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@michalsnik michalsnik

Labels
semver-patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vue/require-default-prop doesn't recognized quoted property name.
2 participants
@michalsnik @chrisvfritz