Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop autofix of prop-name-casing. #940

Merged
merged 2 commits into from Sep 25, 2019
Merged

Conversation

@ota-meshi
Copy link
Member

@ota-meshi ota-meshi commented Aug 10, 2019

This PR removes the prop-name-casing autofix.

The autofix of prop-name-casing breaks the program as pointed out in the following comment.

#402 (comment)

@ota-meshi ota-meshi self-assigned this Aug 14, 2019
@panstromek
Copy link

@panstromek panstromek commented Sep 3, 2019

Yes, please. This fix cost me few days of work and lot of lost time in debugging because I didn't notice it breaks things until bunch of commits later. I already reported it in #864 Thanks for this PR

@bhaidar
Copy link

@bhaidar bhaidar commented Sep 25, 2019

Is this PR ready to be merged?

@kazupon kazupon merged commit edf43ff into master Sep 25, 2019
9 checks passed
@kazupon kazupon deleted the drop-autofix-of-prop-name-casing branch Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants