Skip to content

feat: fewer side effects codegen for <script setup> #2582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 4, 2023
Merged

feat: fewer side effects codegen for <script setup> #2582

merged 3 commits into from
Apr 4, 2023

Conversation

johnsoncodehk
Copy link
Member

  • If <script> block does not exist, directly generate script setup code to root scope instead of wrapping it into function scope.
  • Support props interface for generic component.

Fixes #2421

@johnsoncodehk johnsoncodehk changed the title feat: new <script setup> codegen feat: fewer side effects codegen for <script setup> Apr 4, 2023
@johnsoncodehk johnsoncodehk merged commit ce73539 into master Apr 4, 2023
@johnsoncodehk johnsoncodehk deleted the script-setup-scope branch April 4, 2023 14:44
@johnsoncodehk johnsoncodehk mentioned this pull request Apr 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@johnsoncodehk