Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid npm bug when resolving optional deps #2841

Merged
merged 3 commits into from
Dec 2, 2024
Merged

fix: avoid npm bug when resolving optional deps #2841

merged 3 commits into from
Dec 2, 2024

Conversation

posva
Copy link
Member

@posva posva commented Nov 22, 2024

this makes the package require vue 2.7 but has no code changes

this makes the package require vue 2.7 but has no code changes
Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for pinia-official canceled.

Name Link
🔨 Latest commit 49d4155
🔍 Latest deploy log https://app.netlify.com/sites/pinia-official/deploys/673fd6bb124c400008505f02

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for pinia-playground ready!

Name Link
🔨 Latest commit 49d4155
🔍 Latest deploy log https://app.netlify.com/sites/pinia-playground/deploys/673fd6bbbe9f990008bfe949
😎 Deploy Preview https://deploy-preview-2841--pinia-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Nov 22, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@pinia/nuxt@2841
pnpm add https://pkg.pr.new/pinia@2841
pnpm add https://pkg.pr.new/@pinia/testing@2841

commit: 49d4155

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.84%. Comparing base (31fbff1) to head (49d4155).
Report is 20 commits behind head on v2.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #2841      +/-   ##
==========================================
+ Coverage   88.39%   88.84%   +0.44%     
==========================================
  Files          19       19              
  Lines        1439     1434       -5     
  Branches      227      225       -2     
==========================================
+ Hits         1272     1274       +2     
+ Misses        166      158       -8     
- Partials        1        2       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@posva posva merged commit 1e45f33 into v2 Dec 2, 2024
10 checks passed
@posva posva deleted the vue-2-7 branch December 2, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant