New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Throw style compilation errors #235

Merged
merged 3 commits into from Sep 26, 2018

Conversation

Projects
None yet
2 participants
@Nandiin
Copy link
Contributor

Nandiin commented Sep 21, 2018

Fixes #226.

Changes proposed in this pull request:

  • forward the errors returned from compileStyleAsync to alert user that something has went wrong.

/ping @znck

Show resolved Hide resolved src/index.ts Outdated
Show resolved Hide resolved src/index.ts Outdated
@znck
Copy link
Member

znck left a comment

Prefer const over let.

@znck

znck approved these changes Sep 26, 2018

@znck znck merged commit 5d8aa49 into vuejs:master Sep 26, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment