fix(router): use pagehide for iOS navigation #2537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue-router canceled.
|
posva
requested changes
Aug 3, 2025
packages/router/src/history/html5.ts
Outdated
| for (const teardown of teardowns) teardown() | ||
| teardowns = [] | ||
| window.removeEventListener('popstate', popStateHandler) | ||
| window.removeEventListener('beforeunload', beforeUnloadListener) |
There was a problem hiding this comment.
I think we can remove the beforeunload if we use pagehide
packages/router/src/history/html5.ts
Outdated
| } | ||
|
|
||
| function beforeHiddenListener() { | ||
| document.hidden && beforeUnloadListener() |
|
Provided another commit to fix those, thanks for the fast feedback :) |
posva
approved these changes
Aug 3, 2025
commit: |
posva
changed the title
|
Yup looking good ! Just installed it and the patch works fine on iOS :) Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2536
Steps to reproduce
On iOS safari, scroll to the middle of the page, refresh, it'll go back to top instead of going back to the correct position.
What is expected?
It behaves properly in chrome for e.g., it'd restore the scroll position.
What is actually happening?
It's going back to the top of the page instead of restoring the scroll position.
The code window.addEventListener('beforeunload', beforeUnloadListener) does not trigger on iOS, we should use window.addEventListener('pagehide', ...) instead