Skip to content

types: fix typing for options.attachTo #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2020
Merged

types: fix typing for options.attachTo #120

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76d24be
types: fix typing for options.attachTo
lmiller1990 May 16, 2020
8e36df4
refactor: move check inside if statement
lmiller1990 May 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions src/mount.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,15 +86,18 @@ export function mount(
el.id = MOUNT_ELEMENT_ID

if (options?.attachTo) {
const to = isString(options.attachTo)
? document.querySelector(options.attachTo)
: options.attachTo

if (!to) {
throw new Error(
`Unable to find the element matching the selector ${options.attachTo} given as the \`attachTo\` option`
)
let to: Element
if (typeof options.attachTo === 'string') {
to = document.querySelector(options.attachTo)
if (!to) {
throw new Error(
`Unable to find the element matching the selector ${options.attachTo} given as the \`attachTo\` option`
)
}
} else {
to = options.attachTo
}

to.appendChild(el)
}

Expand Down