chore: typings maintenance in mount #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit tidies up the types in mount. The goal is to enable `strict: true` in the future on the project, and this commit fixes up a bunch of errors that the strict mode complains about.
lmiller1990
approved these changes
May 18, 2020
| if (global.config) { | ||
| for (const [k, v] of Object.entries(global.config)) { | ||
| for (const [k, v] of Object.entries(global.config) as [ | ||
| keyof Omit<AppConfig, 'isNativeTag'>, |
| for (const [k, v] of Object.entries( | ||
| global.mocks as { [key: string]: any } | ||
| )) { | ||
| ;(this as any)[k] = v |
There was a problem hiding this comment.
TS is so ugly sometimes (or maybe due to Vue's dynamic nature it cannot be avoided...)
| export type GlobalMountOptions = { | ||
| plugins?: Plugin[] | ||
| config?: AppConfig | ||
| config?: Omit<AppConfig, 'isNativeTag'> // isNativeTag is readonly, so we omit it |
There was a problem hiding this comment.
so this is how you do it, awesome, was trying to figure this out
|
Great, thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit tidies up the types in mount. The goal is to enable
strict: truein the future on the project, and this commit fixes up a bunch of errors that the strict mode complains about.The only change for VTU users is that
GlobalMountOptions.confignow does not allow to overrideisNativeTagas it is private and readonly inAppConfig: https://github.com/vuejs/vue-next/blob/71a942b25a2cad61c3d670075523c31d296c7089/packages/runtime-core/src/apiCreateApp.ts#L46-L48