chore: shallowMount overloads #124
Conversation
`shallowMount` now has the same signatures than `mount`, to which it delegates the heavy work.
src/mount.ts
Outdated
| } | ||
|
|
||
| // Functional component | ||
| export function shallowMount<TestedComponent extends FunctionalComponent>( |
There was a problem hiding this comment.
If these are the same can we not share the type somehow? Or is this not possible? (Eg, are we not copy-pasting the same 50 or so lines twice?)
There was a problem hiding this comment.
This is a good question, but I don't know how we could easily do that. @pikax maybe?
There was a problem hiding this comment.
is a bit tricky and dirty, but we could have something like this:
export const shallowMount: typeof mount = (...args) => {
mount(args[0], { ...args[1], shallow: true })
}Typescript complains about it, but we can cast the function to unknown first
EDIT: The args are not required, we can have two arguments as we have in mount, but we can't infer the correct type on the implementation
There was a problem hiding this comment.
@pikax I pushed an extra commit with your suggestion 👍 TSD is happy, so it's good enough for me :)
3 participants
shallowMountnow has the same signatures thanmount, to which it delegates the heavy work.