chore(stubs): proper typings #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cexbrayat
commented
Jun 3, 2020
| return h(tag, {}, getSlots(ctx)) | ||
| const render = (ctx: ComponentPublicInstance) => { | ||
| // TS is not happy with this signature, so we cast the Slots as any | ||
| return h(tag, {}, getSlots(ctx) as any) |
There was a problem hiding this comment.
TS is not happy here, as there is no signature of h matching h(string, {}, Slots). But it works, so I added as any even if I don't like it...
There was a problem hiding this comment.
After digging a bit into it, I think this should be fixed in vue-next, and I submitted a PR: vuejs/core#1293
We can merge as is for now, and I'll remove the as any cast if Evan accepts my PR.
lmiller1990
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes a
ts-ignore.