Skip to content

Conversation

freakzlike
Copy link
Collaborator

@freakzlike freakzlike commented Apr 11, 2022

fix #713

@netlify
Copy link

netlify bot commented Apr 11, 2022

Deploy Preview for vue-test-utils-docs ready!

Name Link
🔨 Latest commit c959d01
🔍 Latest deploy log https://app.netlify.com/sites/vue-test-utils-docs/deploys/625a7fc5b062e70008f0404b
😎 Deploy Preview https://deploy-preview-1412--vue-test-utils-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cexbrayat
Copy link
Member

@freakzlike Let me know when this draft PR is ready to be reviewed 👍

@freakzlike freakzlike marked this pull request as ready for review April 13, 2022 17:47
@freakzlike
Copy link
Collaborator Author

@cexbrayat Please take a look. I'm not really good at writing documentions, but I hope it will help someone

Copy link
Member

@cexbrayat cexbrayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One minor comment, and I'm OK to merge 👍


expect(wrapper.vm.user).toBeUndefined()

await flushPromises()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose here you also need to mock the HTTP call one way or another.
IT's fine by me if we don't show how, but maybe a comment would be nice so readers don't expect this to work magically?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cexbrayat cexbrayat merged commit 21b8b4f into vuejs:main Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Test usage of provide
2 participants