repro: beta.16 regressions #150
Conversation
|
PR is now green with the second commit. Do not merge right now, as I need to think about it, and document properly. |
| for (const registrationName in locallyRegisteredComponents) { | ||
| const component = locallyRegisteredComponents[registrationName] | ||
| if (!component['name'] && !component['displayName']) { | ||
| component['name'] = registrationName |
There was a problem hiding this comment.
I wonder if this mutation is going to cause and problems 🤔
|
@lmiller1990 please wait before releasing. I think we can do better (at least, document and test this). Evan commented on Dicsord with a similar idea, but in way that might not lead to problems as this one. But I need to find some time to try it. |
|
I did a release before I saw this, I thought this bug was problematic enough to warrant a release (still in alpha so yeah). Either way, people using stubs will be having a problem, but this should be less problematic than straight up not working, right? 🤔 I will also try to find some time to work on this, been busy between triaging issues in V1, docs... |
I was trying to update VTU 2.x from Vue beta.15 to beta.16 (beta.17 is the same), and we are having some regressions.
It looks like an SFC with just a template tag was passed to
transformVNodeArgsas:{ render: [Function: render], name: 'component-without-name' }and now is passed as:
{ render: [Function: render] }As we need the name for stubbing/shallow mount, we have test failures.