fix: find component after rc.5 refactor (and other minor fixes) #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`devtools` is no longer available in `AppConfig`
We now have proper inference in `defineComponent`, so extra properties need to be declared as `attrs` (as we initially hoped)
Vue 3.0.0-rc.5 introduced a refactoring of the component resolution (see vuejs/core@a75b8a2) This simply fixes our implementation by using `type.components` instead of `.components` that no longer exist. The implementation in `stubs` was already fine as I used `type.components` there.
lmiller1990
approved these changes
Jul 30, 2020
| // if a name is missing, then check the locally registered components in the parent | ||
| if (node.component.parent) { | ||
| const registry = (node.component.parent as any).components | ||
| const registry = (node.component.parent as any).type.components |
There was a problem hiding this comment.
Nice, do we need a check to see if type is not null?
There was a problem hiding this comment.
Good question but it is not marked as nullable in the TS definition of ComponentInternalInstance, so I think we're good (but I do agree we would feel safer if we had strict: true)
| props: { a: 'Hello', c: 2 } | ||
| }) | ||
| // can not receive extra props | ||
| expectError( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each commit explains the reasoning behind the changes, but TL;DR: we had some compilation issue easy to fix, and a small refactor to do after the component resolution changes that Evan did in rc.5.