feat(mount): add support for propsData #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebDevEtc
force-pushed
the
issue-204-support-propsdata
branch
from
6071ca2 to
dd39b86
Compare
lmiller1990
reviewed
Sep 14, 2020
| ? Partial<Data> | ||
| : never | ||
| props?: Props | ||
| propsData?: Props |
There was a problem hiding this comment.
Looks good, what do you think about marking this as deprecated?
https://devblogs.microsoft.com/typescript/announcing-typescript-4-0-beta/#deprecated-support
- Adds support for mounting with `propsData` option, for backwards compatibility. - propsData is marked as deprecated. See vuejs#204
WebDevEtc
force-pushed
the
issue-204-support-propsdata
branch
from
dd39b86 to
1f39d7c
Compare
lmiller1990
approved these changes
Sep 14, 2020
|
Great, thanks @WebDevEtc I will release in the next few days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
propsDataoption,for backwards compatibility.
See #204
Added two tests to be clear what happens when both
propsandpropsDataare provided. Happy to change implementation to a different behaviour if that would be preferred.(No warning/error is given to the user if both
propsandpropsDataare used in the mounting options.)