docs: note mount's dependence on system time
#2100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue-test-utils-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
lmiller1990
reviewed
Jun 20, 2023
docs/guide/faq/index.md
Outdated
|
|
||
| ## Mocking Dates and Timers with Vitest | ||
|
|
||
| `mount` depends on the system time in some way \[needs clarification\]. For |
There was a problem hiding this comment.
Do you intend to clarify? If not, we could make this more generic. For example:
"Some edge cases are known to exist when using Vitest and the vi.setSystemTime that can interfere with Vue's scheduler, causing unexpected behaviors. If you are using setSystemTime, make sure you call it before calling mount to avoid any unexpected behavior".
There was a problem hiding this comment.
Is that better? I'm not clarifying because I don't know anything and don't plan to find out. But you pretty much just clarified. And I paraphrased it.
cexbrayat
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2074