fix: set default event.cancelable from dom-event-types #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #218 which may be caused by a simple typo in the codebase.
It seems like a core intent of
getEventPropertiesis to source default properties of different types of DOM events from the 'dom-event-types' dep and provide them as properties for new events. However, it looks like thecancelableproperty is not being added to the returned object.This change resolves the bug I'm seeing in #218 by allowing
clickevents to havepreventDefaultwork correctly.I'd be happy to add a test case to test against regression here, but it doesn't seem like a logic bug or something that's likely to be reverted if my above assumptions seem reasonable.