wip: class component support #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SFC support is blocked by vue-jest. I will address it on the weekend. Then we should be good for class component 👍 |
|
@lmiller1990 need any help on this this weekend? |
|
Think I've got it covered, I will tag you when I have something up for some help/testing - most of the complexity is in vue-jest. |
|
Ok, this will pass when vuejs/vue-jest#300 is released. vue-jest is blocking class components in SFC files. Once it is merged, I will release both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Class component is not working when declared in a SFC file.
vuejs/vue-jest#297 related maybe.
I will continue adding more test cases here.