Skip to content

Conversation

afontcu
Copy link
Member

@afontcu afontcu commented Jan 16, 2021

PR looks obviously huge but it is due to copy&paste markdown files 😄


/** @type {UserConfig} */
const config = {
// base: '/v2/',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending to figure out where will docs get deployed

@lmiller1990
Copy link
Member

Finally, have been waiting for this.

I did not look at the diff yet, the basic questions I see are:

  1. how do we handle deploys? Can we update this to auto deploy to netlify as we are currently doing (if we cannot, who do we need to ping?)
  2. can this be merged as-is, or does some other config need to happen (or can that happen after merging)?

@afontcu
Copy link
Member Author

afontcu commented Jan 18, 2021

I did not look at the diff yet, the basic questions I see are:
1. how do we handle deploys? Can we update this to auto deploy to netlify as we are currently doing (if we cannot, who do we need to ping?)
2. can this be merged as-is, or does some other config need to happen (or can that happen after merging)?

It is deployed on Netlify so we might need to tweak config to point to this repo. AFAIK this is the only thing missing before merging. I'm not sure we still need to set base to /v2/ or if we could deploy it to a subdomain to make it easier to manage (next.vue-test-utils.vuejs.org)

@lmiller1990
Copy link
Member

We might want to see what Vue Router/Vuex is doing and follow that convention

@afontcu
Copy link
Member Author

afontcu commented Jan 18, 2021

We might want to see what Vue Router/Vuex is doing and follow that convention

Yeah, that's where I got the idea from :) They use subdomains:

https://next.router.vuejs.org/
https://next.vuex.vuejs.org/

@afontcu
Copy link
Member Author

afontcu commented Jan 19, 2021

I'll go ahead and merge this one to be ready when Netlify config changes. Any additional tweaks can be done afterwards! 😃

@afontcu afontcu merged commit 66e191b into master Jan 19, 2021
@afontcu afontcu deleted the port-docs-vitepress branch January 19, 2021 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants