Skip to content

Conversation

xanf
Copy link
Collaborator

@xanf xanf commented Aug 7, 2021

Good code is dead code :)

Stubs created inside mount.ts for global.stubs were never called, since they were replaced by stubComponents during transformVNodeArgs` pass (which is intended and correct)

Removed unneeded code and provide explanation why it works in this way
Super happy to have stubs code living in one place instead of two now :)

@lmiller1990
Copy link
Member

Great catch. RIP dead code, you will be forgotten but you won't be missed.

@lmiller1990 lmiller1990 merged commit 43e303e into vuejs:master Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants