Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix memory leak of detached DOM tree #210

Merged
merged 1 commit into from Dec 17, 2017
Merged

fix: fix memory leak of detached DOM tree #210

merged 1 commit into from Dec 17, 2017

Conversation

ktsn
Copy link
Member

@ktsn ktsn commented Dec 17, 2017

The overwriting _init function causes memory leak because it retains the vm instance even after the data hook is finished. The _init function itself is also kept with the original component class. So we need to free the overwriting _init function after it is used.

fix #209

@ktsn ktsn merged commit 7580098 into master Dec 17, 2017
@ktsn ktsn deleted the fix-memory-leak branch December 17, 2017 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory leak (detached DOM tree) when Vue class component is used
1 participant
@ktsn