vue-cli-service lint crashes on non-fixable error

[m3nowak]

Version

3.2.2

Reproduction link

https://github.com/menmikimen/vue-cli-lint-crash

Environment info

  System:
    OS: Linux 4.19 Fedora 28 (Twenty Eight) 28 (Twenty Eight)
    CPU: (4) x64 Intel(R) Core(TM) i7-6500U CPU @ 2.50GHz
  Binaries:
    Node: 8.12.0 - /usr/bin/node
    Yarn: Not Found
    npm: 6.4.1 - /usr/bin/npm
  Browsers:
    Chrome: Not Found
    Firefox: 64.0
  npmPackages:
    @vue/babel-preset-app:  3.2.2
    @vue/cli-overlay:  3.2.0
    @vue/cli-plugin-babel: ^3.2.0 => 3.2.2
    @vue/cli-plugin-eslint: ^3.2.0 => 3.2.2
    @vue/cli-service: ^3.2.0 => 3.2.2
    @vue/cli-shared-utils:  3.2.2
    @vue/component-compiler-utils:  2.3.1
    @vue/preload-webpack-plugin:  1.1.0
    @vue/web-component-wrapper:  1.2.0
    babel-helper-vue-jsx-merge-props:  2.0.3
    babel-plugin-transform-vue-jsx:  4.0.1
    eslint-plugin-vue: ^5.0.0 => 5.0.0
    vue: ^2.5.21 => 2.5.21
    vue-eslint-parser:  2.0.3
    vue-hot-reload-api:  2.3.1
    vue-loader:  15.4.2
    vue-style-loader:  4.1.2
    vue-template-compiler: ^2.5.21 => 2.5.21
    vue-template-es2015-compiler:  1.6.0
  npmGlobalPackages:
    @vue/cli: 3.2.2

Steps to reproduce

1. Clone linked repo
2. Navigate to lint-crash folder within
3. $ npm install
4. $ npm run lint

What is expected?

Fix first error and display information about second.

What is actually happening?

First error is fixed and information about second is displayed.
However the script crashes after that.

---

Linked repository contains fresh project created with default template (using vue create).
I've added two linter errors in src/main.js file;

• double semicolon (autofixable)
• invocation of non-existing function (non-autofixable)

Crash occurs whenever lint command is run and there are non-fixable errors present.

[m3nowak]

Logs:

Lint command:

[mnowak@localhost lint-crash]$ npm run lint

> lint-crash@0.1.0 lint /home/mnowak/Dev/vue-cli-lint-crash/lint-crash
> vue-cli-service lint

error: 'cleverError' is not defined (no-undef) at src/main.js:7:1:
   5 | Vue.config.productionTip = true;
   6 |
>  7 | cleverError();
     | ^
   8 |
   9 | new Vue({
  10 |   render: h => h(App),


1 error found.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! lint-crash@0.1.0 lint: `vue-cli-service lint`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the lint-crash@0.1.0 lint script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/mnowak/.npm/_logs/2019-01-01T15_13_54_915Z-debug.log

Produced log file:

0 info it worked if it ends with ok
1 verbose cli [ '/usr/bin/node', '/usr/bin/npm', 'run', 'lint' ]
2 info using npm@6.4.1
3 info using node@v8.12.0
4 verbose run-script [ 'prelint', 'lint', 'postlint' ]
5 info lifecycle lint-crash@0.1.0~prelint: lint-crash@0.1.0
6 info lifecycle lint-crash@0.1.0~lint: lint-crash@0.1.0
7 verbose lifecycle lint-crash@0.1.0~lint: unsafe-perm in lifecycle true
8 verbose lifecycle lint-crash@0.1.0~lint: PATH: /usr/lib/node_modules/npm/node_modules/npm-lifecycle/node-gyp-bin:/home/mnowak/Dev/vue-cli-lint-crash/lint-crash/node_modules/.bin:/usr/local/bin:/usr/bin:/bin:/usr/local/sbin:/usr/sbin:/var/lib/snapd/snap/bin:/home/mnowak/.local/bin:/home/mnowak/bin:/home/mnowak/.local/bin:/home/mnowak/bin
9 verbose lifecycle lint-crash@0.1.0~lint: CWD: /home/mnowak/Dev/vue-cli-lint-crash/lint-crash
10 silly lifecycle lint-crash@0.1.0~lint: Args: [ '-c', 'vue-cli-service lint' ]
11 silly lifecycle lint-crash@0.1.0~lint: Returned: code: 1  signal: null
12 info lifecycle lint-crash@0.1.0~lint: Failed to exec lint script
13 verbose stack Error: lint-crash@0.1.0 lint: `vue-cli-service lint`
13 verbose stack Exit status 1
13 verbose stack     at EventEmitter.<anonymous> (/usr/lib/node_modules/npm/node_modules/npm-lifecycle/index.js:301:16)
13 verbose stack     at emitTwo (events.js:126:13)
13 verbose stack     at EventEmitter.emit (events.js:214:7)
13 verbose stack     at ChildProcess.<anonymous> (/usr/lib/node_modules/npm/node_modules/npm-lifecycle/lib/spawn.js:55:14)
13 verbose stack     at emitTwo (events.js:126:13)
13 verbose stack     at ChildProcess.emit (events.js:214:7)
13 verbose stack     at maybeClose (internal/child_process.js:915:16)
13 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:209:5)
14 verbose pkgid lint-crash@0.1.0
15 verbose cwd /home/mnowak/Dev/vue-cli-lint-crash/lint-crash
16 verbose Linux 4.19.10-200.fc28.x86_64
17 verbose argv "/usr/bin/node" "/usr/bin/npm" "run" "lint"
18 verbose node v8.12.0
19 verbose npm  v6.4.1
20 error code ELIFECYCLE
21 error errno 1
22 error lint-crash@0.1.0 lint: `vue-cli-service lint`
22 error Exit status 1
23 error Failed at the lint-crash@0.1.0 lint script.
23 error This is probably not a problem with npm. There is likely additional logging output above.
24 verbose exit [ 1, true ]

I've concluded it may be a permissions issue. However executing this command as root yields similar results:

[mnowak@localhost lint-crash]$ sudo npm run lint
[sudo] password for mnowak:

> lint-crash@0.1.0 lint /home/mnowak/Dev/vue-cli-lint-crash/lint-crash
> vue-cli-service lint

error: 'cleverError' is not defined (no-undef) at src/main.js:7:1:
   5 | Vue.config.productionTip = true;
   6 |
>  7 | cleverError();
     | ^
   8 |
   9 | new Vue({
  10 |   render: h => h(App),


1 error found.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! lint-crash@0.1.0 lint: `vue-cli-service lint`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the lint-crash@0.1.0 lint script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2019-01-01T15_16_19_556Z-debug.log

Log file contents:

0 info it worked if it ends with ok
1 verbose cli [ '/usr/bin/node', '/usr/bin/npm', 'run', 'lint' ]
2 info using npm@6.4.1
3 info using node@v8.12.0
4 verbose run-script [ 'prelint', 'lint', 'postlint' ]
5 info lifecycle lint-crash@0.1.0~prelint: lint-crash@0.1.0
6 info lifecycle lint-crash@0.1.0~lint: lint-crash@0.1.0
7 verbose lifecycle lint-crash@0.1.0~lint: unsafe-perm in lifecycle true
8 verbose lifecycle lint-crash@0.1.0~lint: PATH: /usr/lib/node_modules/npm/node_modules/npm-lifecycle/node-gyp-bin:/home/mnowak/Dev/vue-cli-lint-crash/lint-crash/node_modules/.bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
9 verbose lifecycle lint-crash@0.1.0~lint: CWD: /home/mnowak/Dev/vue-cli-lint-crash/lint-crash
10 silly lifecycle lint-crash@0.1.0~lint: Args: [ '-c', 'vue-cli-service lint' ]
11 silly lifecycle lint-crash@0.1.0~lint: Returned: code: 1  signal: null
12 info lifecycle lint-crash@0.1.0~lint: Failed to exec lint script
13 verbose stack Error: lint-crash@0.1.0 lint: `vue-cli-service lint`
13 verbose stack Exit status 1
13 verbose stack     at EventEmitter.<anonymous> (/usr/lib/node_modules/npm/node_modules/npm-lifecycle/index.js:301:16)
13 verbose stack     at emitTwo (events.js:126:13)
13 verbose stack     at EventEmitter.emit (events.js:214:7)
13 verbose stack     at ChildProcess.<anonymous> (/usr/lib/node_modules/npm/node_modules/npm-lifecycle/lib/spawn.js:55:14)
13 verbose stack     at emitTwo (events.js:126:13)
13 verbose stack     at ChildProcess.emit (events.js:214:7)
13 verbose stack     at maybeClose (internal/child_process.js:915:16)
13 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:209:5)
14 verbose pkgid lint-crash@0.1.0
15 verbose cwd /home/mnowak/Dev/vue-cli-lint-crash/lint-crash
16 verbose Linux 4.19.10-200.fc28.x86_64
17 verbose argv "/usr/bin/node" "/usr/bin/npm" "run" "lint"
18 verbose node v8.12.0
19 verbose npm  v6.4.1
20 error code ELIFECYCLE
21 error errno 1
22 error lint-crash@0.1.0 lint: `vue-cli-service lint`
22 error Exit status 1
23 error Failed at the lint-crash@0.1.0 lint script.
23 error This is probably not a problem with npm. There is likely additional logging output above.
24 verbose exit [ 1, true ]

[LinusBorg]

I don't see anything unusual. When the lint script finds a non-fixable error, it exists with an error. That's by design so you can abort commits or deployments etc when the linter detects any problems.

[m3nowak]

I just didn't expect to see what i presumed to be crash report if linter encounters non-fixable problem.
Now I see that this is standard message displayed whenever nodejs script finishes with status code 1 (which is very odd imo). When I've encounter this message for first time I found it strange, so I filled the issue.

Anyway i think it's best to close/delete this issue.