feat(test): warn developers when they re-use a test project name #1213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This warning would have saved me a fair bit of time during testing because test projects are not cleaned up between individual tests and I kept stepping on previous tests.
|
Hmm this shouldn't be a problem because of the |
|
As long as a clean is run between tests you're good, but if there are
multiple tests in a spec that create test projects they reach need unique
names to run the entire spec. Maybe I should restructure how I write tests
to deal with this.
An example of what I am talking about (or at least was running to when I was working on the feature) are the `should work` and `should not fix with --no-fix option` tests in https://github.com/vuejs/vue-cli/blob/dev/packages/%40vue/cli-plugin-typescript/__tests__/tsPluginTSLint.spec.js . Without having unique names, they kept stepping on each other during a test run because the `test` directory is not cleaned in between different tests in a spec
|
|
Ah ok, yeah it's common to forget changing the test project name after copy pasting when writing tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This warning would have saved me a fair bit of time during testing because test projects are not cleaned up between individual tests and I kept stepping on previous tests. If this is a dumb idea then you can just reject and ignore