Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test): warn developers when they re-use a test project name #1213

Merged
merged 1 commit into from
May 3, 2018

Conversation

dhensche
Copy link
Contributor

@dhensche dhensche commented May 2, 2018

This warning would have saved me a fair bit of time during testing because test projects are not cleaned up between individual tests and I kept stepping on previous tests. If this is a dumb idea then you can just reject and ignore

This warning would have saved me a fair bit of time during testing
because test projects are not cleaned up between individual tests and
I kept stepping on previous tests.
@yyx990803
Copy link
Member

Hmm this shouldn't be a problem because of the --force flag at line 42. Also yarn test runs yarn clean before starting the tests. Not sure how you run into the overwriting problem?

@dhensche
Copy link
Contributor Author

dhensche commented May 3, 2018 via email

@yyx990803
Copy link
Member

Ah ok, yeah it's common to forget changing the test project name after copy pasting when writing tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants