Skip to content

fix(env): preserve existing env vars so load in reverse order. #1503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2018
Merged

fix(env): preserve existing env vars so load in reverse order. #1503

merged 1 commit into from
Jun 7, 2018

Conversation

morrislaptop
Copy link
Contributor

Fixes #1499

@yyx990803
Copy link
Member

yyx990803 commented Jun 7, 2018 •
edited
Loading

Thanks! Can you please add a test case in Service.spec.js making sure .env does not overwrite existing env variables?

@morrislaptop
Copy link
Contributor Author

Modified the env loading test for this. Hope that is OK.

@yyx990803 yyx990803 merged commit 7c1ef24 into vuejs:dev Jun 7, 2018
@morrislaptop morrislaptop deleted the env-specificity branch June 7, 2018 14:57
@yyx990803 yyx990803 mentioned this pull request Jun 9, 2018
Closed
This was referenced Jun 20, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@morrislaptop @yyx990803