Skip to content

fix(modern): send credentials when loading script modules. #1695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 28, 2018
Merged

fix(modern): send credentials when loading script modules. #1695

merged 4 commits into from
Jun 28, 2018

Conversation

trashpanda001
Copy link
Contributor

Otherwise, things like BasicAuth won't work.
See: #1656

@trashpanda001
Copy link
Contributor Author

AppVeyor build failure is unrelated to this pull request.

@trashpanda001 trashpanda001 changed the title Send credentials when loading script modules. fix(modern): send credentials when loading script modules. Jun 28, 2018
@Akryum Akryum merged commit e2a7063 into vuejs:dev Jun 28, 2018
@yyx990803
Copy link
Member

Note: the default has been reverted to anonymous CORS in 30215c2 and you will need to use corsUseCredentials: true in vue.config.js to enforce crossorigin="use-credentials" in the next release (after RC5).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trashpanda001 @yyx990803 @Akryum