Skip to content

WIP: fix underscore escaping for dotfiles #1737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 4, 2018
Merged

WIP: fix underscore escaping for dotfiles #1737

merged 4 commits into from
Jul 4, 2018

Conversation

LinusBorg
Copy link
Member

(fix #1732)

@LinusBorg
Copy link
Member Author

Thanks for fixing the typo ^^

Akryum
Akryum reviewed Jul 3, 2018
View reviewed changes
docs/dev-guide/plugin-dev.md Outdated
@@ -235,6 +235,30 @@ export default {
<%# END_REPLACE %>
```

#### Edge cases

If you want to render a template file that either begins with a dot (i.e. `.env`) you will have to follow a specific naming convention, since dotfiles are ignored:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"by npm"?

@Akryum Akryum merged commit a9aa3de into dev Jul 4, 2018
@Akryum Akryum deleted the LinusBorg-patch-issue-1732 branch July 4, 2018 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akryum Akryum Akryum left review comments

+1 more reviewer

@pksunkara pksunkara pksunkara approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Template files starting with an underscore are renamed to a start with a period
3 participants
@LinusBorg @pksunkara @Akryum